[FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

Nicolas George george at nsup.org
Tue Jul 27 00:54:46 EEST 2021


Marton Balint (12021-07-26):
> As far as I remember AVBPrint buffer CAN be read in place by design, zero
> terminator is always guaranteed, not only after finalizing. So this should
> not be needed. What is causing the invalid reads exactly?

I confirm your memory. The documentation states:

 * The string buffer grows as necessary and is always 0-terminated.

And I checked: there is no obvious bug in the avio_read_to_bprint() code
path, it ends with av_bprint_grow() adding the final 0.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210726/f8cbe63a/attachment.sig>


More information about the ffmpeg-devel mailing list