[FFmpeg-devel] [PATCH] lavfi/signature: fix always true expression

[Jai Luthra]

On Mon, May 24, 2021 at 04:00:24AM +0300, Valerii Zapodovnikov wrote:
>Otherwise since "==" has higher precedence, mode is never checked.
>---
> libavfilter/signature_lookup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c
>index 272c717c77..85e879d224 100644
>--- a/libavfilter/signature_lookup.c
>+++ b/libavfilter/signature_lookup.c
>@@ -491,7 +491,7 @@ static MatchingInfo evaluate_parameters(AVFilterContext *ctx, SignatureContext *
>         meandist = (double) goodfcount / (double) distsum;
>
>         if (meandist < minmeandist ||
>-                status == STATUS_END_REACHED | STATUS_BEGIN_REACHED ||
>+                status == (STATUS_END_REACHED | STATUS_BEGIN_REACHED) ||
>                 mode == MODE_FAST){
>             minmeandist = meandist;
>             /* bestcandidate in this iteration */

will apply thx!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210725/b7bd6812/attachment.sig>