[FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

"zhilizhao(赵志立)" quinkblack at foxmail.com
Tue Jul 20 11:09:14 EEST 2021



> On Jul 20, 2021, at 3:50 PM, Steven Liu <lingjiujianke at gmail.com> wrote:
> 
> Thilo Borgmann <thilo.borgmann at mail.de> 于2021年7月20日周二 下午3:37写道:
>> 
>> Am 20.07.21 um 03:46 schrieb Andreas Rheinhardt:
>>> Steven Liu:
>>>> From: Steven Liu <liuqi05 at kuaishou.com>
>>>> 
>>>> Because these two member of AVFContext not be used.
>>>> 
>>>> Signed-off-by: Steven Liu <liuqi05 at kuaishou.com>
>>>> ---
>>>> libavdevice/avfoundation.m | 4 ----
>>>> 1 file changed, 4 deletions(-)
>>>> 
>>>> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
>>>> index bad3760159..5b4dea826c 100644
>>>> --- a/libavdevice/avfoundation.m
>>>> +++ b/libavdevice/avfoundation.m
>>>> @@ -85,8 +85,6 @@ typedef struct
>>>> 
>>>>     int             frames_captured;
>>>>     int             audio_frames_captured;
>>>> -    int64_t         first_pts;
>>>> -    int64_t         first_audio_pts;
>>>>     pthread_mutex_t frame_lock;
>>>>     id              avf_delegate;
>>>>     id              avf_audio_delegate;
>>>> @@ -766,8 +764,6 @@ static int avf_read_header(AVFormatContext *s)
>>>>     NSArray *devices_muxed = [AVCaptureDevice devicesWithMediaType:AVMediaTypeMuxed];
>>>> 
>>>>     ctx->num_video_devices = [devices count] + [devices_muxed count];
>>>> -    ctx->first_pts          = av_gettime();
>>>> -    ctx->first_audio_pts    = av_gettime();
>>>> 
>>>>     pthread_mutex_init(&ctx->frame_lock, NULL);
>>>> 
>>>> 
>>> This is the third time that you sent this patch, although it has already
>>> been pushed yesterday (as b67263e0e88ebb1001552190212159ff7e25cc07) by
>>> Thilo Borgmann; he announced this here:
>>> https://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282436.html
>> 
>> Might these be still side-effects from ML delay for your mail, Steven?
> Maybe my mail client problem, sometime cannot receive email fully from ML.

Me too. I can’t receive my owner patch email from ffmpeg-devel. I checked patchwork
or http://ffmpeg.org/pipermail/ffmpeg-devel to make sure it has been sent successfully.

> 
>> 
>> -Thilo
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list