[FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

Thilo Borgmann thilo.borgmann at mail.de
Tue Jul 20 10:37:21 EEST 2021


Am 20.07.21 um 03:46 schrieb Andreas Rheinhardt:
> Steven Liu:
>> From: Steven Liu <liuqi05 at kuaishou.com>
>>
>> Because these two member of AVFContext not be used.
>>
>> Signed-off-by: Steven Liu <liuqi05 at kuaishou.com>
>> ---
>>  libavdevice/avfoundation.m | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
>> index bad3760159..5b4dea826c 100644
>> --- a/libavdevice/avfoundation.m
>> +++ b/libavdevice/avfoundation.m
>> @@ -85,8 +85,6 @@ typedef struct
>>  
>>      int             frames_captured;
>>      int             audio_frames_captured;
>> -    int64_t         first_pts;
>> -    int64_t         first_audio_pts;
>>      pthread_mutex_t frame_lock;
>>      id              avf_delegate;
>>      id              avf_audio_delegate;
>> @@ -766,8 +764,6 @@ static int avf_read_header(AVFormatContext *s)
>>      NSArray *devices_muxed = [AVCaptureDevice devicesWithMediaType:AVMediaTypeMuxed];
>>  
>>      ctx->num_video_devices = [devices count] + [devices_muxed count];
>> -    ctx->first_pts          = av_gettime();
>> -    ctx->first_audio_pts    = av_gettime();
>>  
>>      pthread_mutex_init(&ctx->frame_lock, NULL);
>>  
>>
> This is the third time that you sent this patch, although it has already
> been pushed yesterday (as b67263e0e88ebb1001552190212159ff7e25cc07) by
> Thilo Borgmann; he announced this here:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282436.html

Might these be still side-effects from ML delay for your mail, Steven?

-Thilo


More information about the ffmpeg-devel mailing list