[FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

[James Almer]

On 7/19/2021 6:47 PM, Thilo Borgmann wrote:
> Am 19.07.21 um 23:20 schrieb James Almer:
>> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote:
>>> Thilo Borgmann:
>>>> Hi,
>>>>
>>>> $subject for the new force cpu count function.
>>>>
>>>> Thanks,
>>>> Thilo
>>>>
>>>
>>> I just wanted to complain that you did not modify APIchanges as well;
>>> but then I noticed that there is no entry there for this new function.
>>> But there should be.
>>
>> No version bump either, so this patch should definitely do both things.
> 
> Ok, does the attached look better?

You need to bump the library version when you add new API. Since you 
didn't when you first added the function, you can do it now.
And of course, the version you report in doc/APIchanges should be the 
one that introduced the new API.

> 
> Also, is the commit hash meant be added in a separate commit later to doc/APIchanges?

The hash is added later, once you know the hash of the commit you're 
pushing. We usually add many in batches.

> 
> Thanks!
> -Thilo
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>