[FFmpeg-devel] [PATCH 1/3] avcodec: add a parser flag to enable keyframe tagging heuristics

Michael Niedermayer michael at niedermayer.cc
Thu Jul 15 23:23:12 EEST 2021


On Wed, Jul 14, 2021 at 11:33:59AM -0300, James Almer wrote:
> It will be used to allow parsers to be more liberal when tagging packets as
> keyframes.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/avcodec.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 8b97895aeb..8e3d888266 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2809,6 +2809,7 @@ typedef struct AVCodecParserContext {
>  #define PARSER_FLAG_ONCE                      0x0002
>  /// Set if the parser has a valid file offset
>  #define PARSER_FLAG_FETCHED_OFFSET            0x0004
> +#define PARSER_FLAG_USE_KEYFRAME_HEURISTICS   0x0008
>  #define PARSER_FLAG_USE_CODEC_TS              0x1000

This doesnt "feel" like the best solution to me

dont you think it would be better to export all information ?

the concept of a keyframe is a point at which decoding can begin
that really are at least 3 points

the point at which packets begin to be input into the decoder

the point at which the decoder is able to return some decoded
data which closely resembles the encoder input

and the point at which the decoder output matches 1:1 the output
of a decoder starting from frame 0



Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210715/3dd49e61/attachment.sig>


More information about the ffmpeg-devel mailing list