[FFmpeg-devel] [PATCH] configure: use pkg-config for xlib/Xv

James Almer jamrial at gmail.com
Thu Jul 15 00:28:32 EEST 2021


On 7/14/2021 6:23 PM, Timo Rothenpieler wrote:
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 2d2d125fd3..f5370b3ead 100755
> --- a/configure
> +++ b/configure
> @@ -6194,7 +6194,7 @@ check_func_headers windows.h Sleep
>   check_func_headers windows.h VirtualAlloc
>   check_func_headers glob.h glob
>   enabled xlib &&
> -    check_lib xlib "X11/Xlib.h X11/extensions/Xvlib.h" XvGetPortAttribute -lXv -lX11 -lXext
> +    check_pkg_config xlib "xv" "X11/Xlib.h X11/extensions/Xvlib.h" XvGetPortAttribute

No need for quotes if you're just checking for xv.

LGTM either way, but probably keep the existing check as fallback.

>   
>   check_headers direct.h
>   check_headers dirent.h
> 



More information about the ffmpeg-devel mailing list