[FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

Kieran Kunhya kieran618 at googlemail.com
Tue Jul 13 05:44:40 EEST 2021


On Tue, 13 Jul 2021, 02:45 James Almer, <jamrial at gmail.com> wrote:

> On 7/12/2021 10:01 PM, Kieran Kunhya wrote:
> >>
> >> Because it isn't something that should be marked as a keyframe as coded
> >> bitstream in any kind of container, like it's the case of mp4 sync
> samples.
> >>
> >
> > MPEG-TS Random Access Indicator expects keyframes to be signalled like
> this.
> > With intra-refresh and this code removed, there will be no random access
> > points at all.
>
> If MPEG-TS wants to tag packets containing things other than IDR access
> units as RAPs, then it should analyze the bitstream itself in order to
> tag them itself as such in the output.
> This parser as is is generating invalid output for other containers that
> are strict about key frames, and signal recovery points (like those
> indicated by the use of this SEI) by other means.
>

Why not just detect IDR in containers that only care about that (which is a
mistake because if things like open gop)? Doing that's is relatively simple
compared to adding bitstream parsing into MPEGTS.

Kieran


More information about the ffmpeg-devel mailing list