[FFmpeg-devel] [PATCH] fate/oggvorbis: Fix tests after fixing AV_PKT_DATA_SKIP_SAMPLES

Lynne dev at lynne.ee
Mon Jul 12 10:57:46 EEST 2021


10 Jul 2021, 02:12 by sunguangyucn at gmail.com:

> After fixing AV_PKT_DATA_SKIP_SAMPLES for reading vorbis packets from ogg,
> the actual decoded samples become fewer. Three fate tests are failing:
>
> fate-vorbis-20:
> The samples in 6.ogg are not frame aligned. 6.pcm file was generated by
> ffmpeg before the fix. After the fix, the decoded pcm file does not match
> anymore. Ideally the ref file 6.pcm should be updated but it is probably
> not worth it including another copy of the same file, only smaller.
> SIZE_TOLERANCE is added for this test case.
>
> fate-webm-dash-chapters:
> The original vorbis_chapter_extension_demo.ogg is transmuxed to dash-webm.
> The ref file webm-dash-chapters needs to be updated.
>
> fate-vorbis-encode:
> This exposes another bug in the vorbis encoder that initial_padding is not
> correctly set. It is fixed in the previous patch.
>
> Signed-off-by: Guangyu Sun <gsun at roblox.com>
> ---
>  tests/fate/vorbis.mak             | 1 +
>  tests/ref/fate/webm-dash-chapters | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>

Pushed the patchset, thanks


More information about the ffmpeg-devel mailing list