[FFmpeg-devel] [PATCH 1/9] cbs_av1: fix incorrect data type

Wang, Fei W fei.w.wang at intel.com
Thu Jul 1 11:21:24 EEST 2021


On Mon, 2021-06-21 at 09:38 +0800, Fei.Wang wrote:
> On Thu, 2021-06-17 at 14:10 +0800, Fei Wang wrote:
> > shifted_order_hints is computed by data with int plus data with
> > int.
> > Switch to int8_t may lose its precision.
> > 
> > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > ---
> >  libavcodec/cbs_av1_syntax_template.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/cbs_av1_syntax_template.c
> > b/libavcodec/cbs_av1_syntax_template.c
> > index 6fe6e9a4f3..956d45e132 100644
> > --- a/libavcodec/cbs_av1_syntax_template.c
> > +++ b/libavcodec/cbs_av1_syntax_template.c
> > @@ -355,7 +355,7 @@ static int
> > FUNC(set_frame_refs)(CodedBitstreamContext *ctx, RWContext *rw,
> >          AV1_REF_FRAME_ALTREF2, AV1_REF_FRAME_ALTREF
> >      };
> >      int8_t ref_frame_idx[AV1_REFS_PER_FRAME],
> > used_frame[AV1_NUM_REF_FRAMES];
> > -    int8_t shifted_order_hints[AV1_NUM_REF_FRAMES];
> > +    int shifted_order_hints[AV1_NUM_REF_FRAMES];
> 
> Hi,
> Ping for review this patch set. Thanks.

Hi James,

Free to help review this patch set? This change improved VAAPI av1
decoder quality quite a lot base on our test result, and I believe it
can benefit to all other HW av1 decoders too.

Thanks
> 
> Fei
> 
> >      int cur_frame_hint, latest_order_hint, earliest_order_hint,
> > ref;
> >      int i, j;
> >  


More information about the ffmpeg-devel mailing list