[FFmpeg-devel] [PATCH] libavformat: add librist protocol

[Marton Balint]

On Sun, 31 Jan 2021, Marton Balint wrote:

>
>
> On Tue, 26 Jan 2021, Paul B Mahol wrote:
>
>> This work is sponsored by Open Broadcast Systems.
>>
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>> configure               |   5 +
>> doc/protocols.texi      |  32 +++++
>> libavformat/Makefile    |   1 +
>> libavformat/librist.c   | 251 ++++++++++++++++++++++++++++++++++++++++
>> libavformat/protocols.c |   1 +
>> 5 files changed, 290 insertions(+)
>> create mode 100644 libavformat/librist.c
>>
>
> [...]
>
>> +typedef struct RISTContext {
>> +    const AVClass *class;
>> +
>> +    int profile;
>> +    int buffer_size;
>> +    int packet_size;
>> +    int log_level;
>> +    int encryption;
>> +    char *secret;
>> +
>> +    struct rist_logging_settings logging_settings;
>> +    struct rist_peer_config peer_config;
>
> Can you avoid these on the stack? If librist adds new members to them, 
> this might break, and there is now API for freeing them properly.

Obviously what I meant is avoiding librist structs directly in our data 
structures.

Thanks,
Marton