[FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

[Xiang, Haihao]

On Wed, 2021-01-27 at 13:44 +0100, Anton Khirnov wrote:
> Quoting Xu Guangxin (2021-01-05 03:43:37)
> > ---
> >  libavcodec/qsvdec_h2645.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c
> > index 02c41883b6..3d6e85230f 100644
> > --- a/libavcodec/qsvdec_h2645.c
> > +++ b/libavcodec/qsvdec_h2645.c
> > @@ -69,6 +69,8 @@ static av_cold int qsv_decode_close(AVCodecContext *avctx)
> >  {
> >      QSVH2645Context *s = avctx->priv_data;
> >  
> > +    av_freep(&s->qsv.load_plugins);
> 
> Does this not get freed by av_opt_free()?
> 

Yes, it gets freed by av_opt_free() when closing the AVCodecContext, we may
remove the above code from qsvdec. 

Thanks
Haihao