[FFmpeg-devel] [PATCH] avpacket: RFC for ABI bump additions

Anton Khirnov anton at khirnov.net
Wed Jan 27 11:16:52 EET 2021


Quoting James Almer (2021-01-26 20:11:16)
> On 1/26/2021 1:17 PM, Anton Khirnov wrote:
> > We could start by adding a field to AVPacket that would be set to a
> > magic value by av_packet_alloc().
> > Then have e.g. AVCodecContext/AVFormatContext warn when they see a
> > packet without this magic value.
> 
> I don't like much the idea of adding a public field just to emit a 
> deprecation warning.


int internal_do_not_touch; // do not touch

is not really public. It is visible in the public headers, but so are
all the AVFooInternal. I agree that it is not the prettiest thing ever,
but it's not too bad.

And I believe it would solve a real problem, since we have few other
ways to let our users know they need to change something. Most of them
do not follow development closely, I'd think.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list