[FFmpeg-devel] [PATCH 2/2] avfilter/vf_unsharp: Remove unnecessary ;

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Jan 26 15:37:51 EET 2021


Andreas Rheinhardt:
> A macro that expands to a function definition might look like a
> declaration, but it isn't and therefore an extra ';' at the end is
> unnecessary and actually invalid (both GCC and Clang warn about this
> when using -pedantic).
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/vf_unsharp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c
> index e9b6c9008d..198dbbaa51 100644
> --- a/libavfilter/vf_unsharp.c
> +++ b/libavfilter/vf_unsharp.c
> @@ -139,8 +139,8 @@ static int name##_##nbits(AVFilterContext *ctx, void *arg, int jobnr, int nb_job
>      }                                                                                                 \
>      return 0;                                                                                         \
>  }
> -DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16);
> -DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8);
> +DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16)
> +DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8)
>  
>  static int apply_unsharp_c(AVFilterContext *ctx, AVFrame *in, AVFrame *out)
>  {
> 
Will apply soon.

- Andreas


More information about the ffmpeg-devel mailing list