[FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

[emcodem at ffastrans.com]

On 2021-01-17 09:02, wrote Stephen Hutchinson:
> Going into detail about GetParity wouldn't be necessary if it's not
> used (and there aren't any other invoke-parsed functions aside from
> checking with Import() whether the script actually returns a clip),
> so the comment could be shortened.  Also, since this is the avisynth
> demuxer, 'in the avs' would be better rendered as 'in the script',
> and simply refer to 'source plugins' rather than 'avisynth source
> plugins'.
> 
> Comment bikeshedding aside, LGTM, but the avs_is* API usage added here
> needs to be reflected in the AVSC_DECLARE_FUNC and LOAD_AVS_FUNC 
> blocks.
> If those parts of the API are present in 2.5, the LOAD_AVS_FUNC can be 
> a
> 0. If they were added in 2.6 (or Plus, but I know these would have to 
> be
> from classic AviSynth), then it should be 1.

Thanks for the very quick reply, i shortened the comment but as the 
whole comment is basically just there to explain why i decided to not 
involve getparity, i believe it is worth to mention in order to save 
some time for possible future committers.

What i am not able to do is to add the used convenience functions 
avs_is_tff and bff to AVSC_DECLARE_FUNC and LOAD_AVS_FUNC, it refuses to 
compile when i do so. IMHO this is because it is just convenience 
functions that's function body is defined in the linked avisynth_c.h 
file instead of being exported by the avisynth api lib.
The existing code in avisynth.c also uses such convenience functions 
without adding them to the declaration, examples:
avs_has_video, line 524
avs_is_clip, line 571

Also, i found it safe to use the convenience functions avs_is_tff and 
bff because the minimum required version is 2.6 and Plus or above, so i 
hoped the functions will be always available.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Populate-field-order-returned-by-avs-script-Trac-Tic.patch
Type: text/x-diff
Size: 1560 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210117/8f04a9b9/attachment.patch>