[FFmpeg-devel] [PATCH 3/7] avutil/parseutils: Check sign in av_parse_time()

[Michael Niedermayer]

On Fri, Jan 15, 2021 at 09:36:26PM +0100, Marton Balint wrote:
> 
> 
> On Thu, 14 Jan 2021, Michael Niedermayer wrote:
> 
> > Fixes: signed integer overflow: -9223372053736 * 1000000 cannot be represented in type 'long'
> > Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6607924558430208
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> > libavutil/parseutils.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
> > index 167e822648..6161f4ac95 100644
> > --- a/libavutil/parseutils.c
> > +++ b/libavutil/parseutils.c
> > @@ -736,7 +736,7 @@ int av_parse_time(int64_t *timeval, const char *timestr, int duration)
> >     if (*q)
> >         return AVERROR(EINVAL);
> > 
> > -    if (INT64_MAX / suffix < t)
> > +    if (t < 0 || INT64_MAX / suffix < t)
> 
> This does not look right, because a negative t can mean a date before 1970.

indeed ive somehow mixed something up between the negative duration handling
and the documentation of the error code.
Will post a better patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210116/8e16e324/attachment.sig>