[FFmpeg-devel] [PATCH 6/6] fft_fixed: remove 16-bit FFT code

Lynne dev at lynne.ee
Tue Jan 12 10:11:24 EET 2021


Jan 12, 2021, 08:50 by andreas.rheinhardt at gmail.com:

> Lynne:
>
>> Jan 9, 2021, 20:22 by dev at lynne.ee:
>>
>>> No longer used by anything. 
>>> Unfortunately the old FFT_FLOAT/FFT_FIXED_32 is left as-is. It's
>>> simply too much work for code meant to be all removed anyway.
>>>
>>> Patch attached. Read patch 1/6 to see the size savings.
>>>
>> Forgot to remove the tests, making FATE fail.
>> Fixed, patch attached.
>>
> According to patchwork, even the very first of your patches doesn't pass
> FATE. And given that your second version (of the first patch) didn't
> change anything wrt FATE, it won't be different with v2.
>

Why are you posting this as a reply to this patch then?
I only tested fate-ac3 and fate-fft. This wasn't covered by either.
Fixed locally. It was a 2-char fix in fate-unknown_layout-ac3.



More information about the ffmpeg-devel mailing list