[FFmpeg-devel] [PATCH 1/1] bug: test pointer to be used.

[James Almer]

On 1/4/2021 3:11 PM, AlexisWilke wrote:
> Two tests check the opposite pointer before using it. If only one of these
> is set to a valid pointer, one of these functions will crash, the other will
> ignore the pointer.
> ---
>   libavformat/allformats.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/allformats.c b/libavformat/allformats.c
> index 0e0caaad39..6990af55f4 100644
> --- a/libavformat/allformats.c
> +++ b/libavformat/allformats.c
> @@ -541,7 +541,7 @@ const AVOutputFormat *av_muxer_iterate(void **opaque)
>   
>       if (i < size) {
>           f = muxer_list[i];
> -    } else if (indev_list) {
> +    } else if (outdev_list) {
>           f = outdev_list[i - size];
>       }
>   
> @@ -558,7 +558,7 @@ const AVInputFormat *av_demuxer_iterate(void **opaque)
>   
>       if (i < size) {
>           f = demuxer_list[i];
> -    } else if (outdev_list) {
> +    } else if (indev_list) {
>           f = indev_list[i - size];
>       }

Applied. Thanks.