[FFmpeg-devel] [PATCH] avformat/fifo: utilize a clone packet for muxing

[Jan Ekström]

On Tue, Dec 8, 2020 at 2:54 PM Jan Ekström <jeebjp at gmail.com> wrote:
>
> From: Jan Ekström <jan.ekstrom at 24i.com>
>
> This way the timestamp adjustments do not have to be manually
> undone in case of failure and need to recover/retry.
>
> Fixes an issue where the timestamp adjustment would be re-done over
> and over again when recovery by muxing the same AVPacket again is
> attempted. Would become visible if the fifo muxer's time base and
> the output muxer's time base do not match (by the value either
> becoming smaller and smaller, or larger and larger).
>
> Signed-off-by: Jan Ekström <jan.ekstrom at 24i.com>

Ping.

Unless someone finds some disgruntling points in this patch, I will
soon move towards applying this.

My initial plan was to make a simplified v2 where the output AVPacket
was on stack limited to the fifo_thread_write_packet context, but
apparently gradual removal of stack usage of AVPackets is being
planned, so I decided to not to.

Best regards,
Jan