[FFmpeg-devel] [PATCH v2 2/3] avformat/udp: add memory alloc checks

[Chad Fraleigh]

On 1/7/2021 2:43 AM, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>   libavformat/udp.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index 798b789..e6d1235 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -891,6 +891,10 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>       if ((!is_output && s->circular_buffer_size) || (is_output && s->bitrate && s->circular_buffer_size)) {
>           /* start the task going */
>           s->fifo = av_fifo_alloc(s->circular_buffer_size);
> +        if (s->fifo) {
> +            ret = AVERROR(ENOMEM);
> +            goto fail;
> +        }

Is this suppose to be  "if (!s->fifo)"  [i.e. fail on NULL] instead?


>           ret = pthread_mutex_init(&s->mutex, NULL);
>           if (ret != 0) {
>               av_log(h, AV_LOG_ERROR, "pthread_mutex_init failed : %s\n", strerror(ret));
>