[FFmpeg-devel] [PATCH 1/5] avformat/udp: add memory alloc checks

[Marton Balint]

On Wed, 6 Jan 2021, lance.lmwang at gmail.com wrote:

> From: Limin Wang <lance.lmwang at gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
> libavformat/udp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index 13c346a..d33e4d6 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -892,6 +892,10 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>
>         /* start the task going */
>         s->fifo = av_fifo_alloc(s->circular_buffer_size);
> +        if (!s->fifo) {
> +            av_log(h, AV_LOG_ERROR, "av_fifo_alloc failed\n");
> +            goto fail;
> +        }

This looks good in principal, but I'd rather not log error messages for 
simple ENOMEM cases. I'd perfer if you could forward the ENOMEM error as a 
function return value and remove the error message.

Thanks,
Marton

>         ret = pthread_mutex_init(&s->mutex, NULL);
>         if (ret != 0) {
>             av_log(h, AV_LOG_ERROR, "pthread_mutex_init failed : %s\n", strerror(ret));
> -- 
> 1.8.3.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".