[FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

[Nicolas George]

Andreas Rheinhardt (12021-01-04):
> What enumerating code? It is actually commonplace that options are
> shared (you can find examples in libavfilter by using 'git grep -e
> define --and -e options'); pointing into other options and thereby
> reusing only a part of other options is not common, but I don't really
> see why it shouldn't work.

Using #define to de-duplicate the source is fine, of course.

But IIRC pointing to the same array, i.e. de-duplicating in the binary,
will lead to the code that enumerate options to loop in some way. I do
not remember the details, and I cannot find a commit that talks about
it, sorry. Maybe somebody here remembers better?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210104/27d1941b/attachment.sig>