[FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build warning for [-Wdiscarded-qualifiers]

[Guo, Yejun]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Paul B
> Mahol
> Sent: 2021年2月26日 19:37
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Cc: Guo, Yejun <yejun.guo at intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build
> warning for [-Wdiscarded-qualifiers]
> 
> look at same/similar patches like yours that have been already rejected.

thanks for the info.

My motivation to fix the build warnings is that: I have several patches caught
by patchwork with build warnings that I missed. I'd like to avoid it. And the best method,
IMO, is to add '-Wall -Werror' for the build option. Such option can also help to find
potential issues in the code. This is the reason that I plan to fix the build warnings
one by one together with community.

Looks that there are build warnings hard to have a nice fix, I'll reconsider my plan, thanks.

> 
> On Fri, Feb 26, 2021 at 9:48 AM Guo, Yejun <yejun.guo at intel.com> wrote:
> 
> > src/libavformat/protocols.c: In function ‘avio_enum_protocols’:
> > src/libavformat/protocols.c:116:7: warning: assignment discards ‘const’
> > qualifier from pointer target type [-Wdiscarded-qualifiers]
> >      p = p ? p + 1 : url_protocols;
> >        ^
> >
> > Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> > ---
> >  libavformat/protocols.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/protocols.c b/libavformat/protocols.c index
> > 7df18fbb3b..86cde84a31 100644
> > --- a/libavformat/protocols.c
> > +++ b/libavformat/protocols.c
> > @@ -113,7 +113,7 @@ const char *avio_enum_protocols(void **opaque,
> int
> > output)
> >  {
> >      const URLProtocol **p = *opaque;
> >
> > -    p = p ? p + 1 : url_protocols;
> > +    p = p ? p + 1 : (const URLProtocol **)url_protocols;
> >      *opaque = p;
> >      if (!*p) {
> >          *opaque = NULL;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".