[FFmpeg-devel] [PATCH] filters/metadata: add CSV output support

Werner Robitza werner.robitza at gmail.com
Wed Feb 24 23:00:09 EET 2021


On Wed, Feb 24, 2021 at 9:51 PM Nicolas George <george at nsup.org> wrote:
> I never told you to duplicate code. Code duplication is almost always a
> motive for rejection.
>
> If you are tempted to duplicate code, what you need to do is to share it
> between the various places that use it. Making it a proper API if
> relevant.

I didn't really duplicate anything; this was mostly from scratch. The
case could be made that a function for escaping CSV could be shared.
There are at least two such functions already in the code base.

> Ideally, all the writers of ffprobe should be turned into a single
> libavutil API for use in all components that need to output data.

That'd make sense.


More information about the ffmpeg-devel mailing list