[FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

[Paul B Mahol]

On Sun, Feb 21, 2021 at 2:23 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol <onemda at gmail.com
> >:
> >
> > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
> >
> > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol <
> onemda at gmail.com
> > > >:
> > > >
> > > > Because there is not point in it.
> > > > Number of frames should always be probed.
> > >
> > > It is neither necessary nor useful to probe it.
> > > Both is immediately obvious:
> > > You already check 48 bits, ruling out one possible value
> > > for 32bit does not improve this detection.
> > > The value is not needed for correct decoding.
> >
> > NAK, This is final decision. Give up.
>
> > Make something more useful.
>
> I do consider this useful:
> Nobody will ever look at this code again except
> if another developer uses it as blueprint for a
> bad probe function.
> And that is apart from the question how unlikely
> it is that a game exists where the imx files do not
> store the number of frames.
>
> Why can't you concentrate on things I know
> nothing about and let me do the boring stuff?
>

This is wrong stuff to do.

Better remove not needed header  above.

>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".