[FFmpeg-devel] [PATCH 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

[Lynne]

Feb 19, 2021, 07:59 by yejun.guo at intel.com:

> Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> ---
>  doc/APIchanges      | 2 ++
>  libavutil/frame.c   | 1 +
>  libavutil/frame.h   | 7 +++++++
>  libavutil/version.h | 2 +-
>  4 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/doc/APIchanges b/doc/APIchanges
> index c353d2d281..3c6e9e351e 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -14,6 +14,8 @@ libavutil:     2017-10-21
>

This won't really work.
Side data must be public but the header it's specified in is neither installed,
neither in lavu. There's no such thing as ffmpeg-only private data.

If we do plan to make this side data public, it'll require a lot more considerations,
and versioning like with the film grain side data, since as you pointed out it may
be used by codecs.

For now, although it's somewhat less appropriate, you can replace
the side data with frame->private_ref. It's an AVBufferRef that's for
use by a single internal library, and we don't use it anywhere except
in lavc for now.