[FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_scale.c

James Almer jamrial at gmail.com
Fri Feb 19 16:42:41 EET 2021


On 2/19/2021 10:55 AM, Alan Kelly wrote:
> Initialises each item in src and filter arrays to fix valgrind
> uninitialised value warning.
> ---
>   casts pointers to uint8_t* and multiplies the buffer size by sizeof(uint16_t).
>   tests/checkasm/sw_scale.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c
> index 7504f8b45f..e3bedd57c6 100644
> --- a/tests/checkasm/sw_scale.c
> +++ b/tests/checkasm/sw_scale.c
> @@ -86,8 +86,8 @@ static void check_yuv2yuvX(void)
>           uint16_t coeff[8];
>       } *vFilterData;
>       uint8_t d_val = rnd();
> -    randomize_buffers(filter_coeff, LARGEST_FILTER);
> -    randomize_buffers(src_pixels, LARGEST_FILTER * LARGEST_INPUT_SIZE);
> +    randomize_buffers((uint8_t*)src_pixels, LARGEST_FILTER * LARGEST_INPUT_SIZE * sizeof(uint16_t));
> +    randomize_buffers((uint8_t*)filter_coeff, LARGEST_FILTER * sizeof(uint16_t));
>       ctx = sws_alloc_context();
>       if (sws_init_context(ctx, NULL, NULL) < 0)
>           fail();

Applied. Thanks.


More information about the ffmpeg-devel mailing list