[FFmpeg-devel] [PATCH v2 2/6] avformat/mxfenc: Use user-specified version even when bitexact

Tomas Härdin tjoppen at acc.umu.se
Thu Feb 18 10:10:54 EET 2021


mån 2021-02-15 klockan 17:55 +0100 skrev Andreas Rheinhardt:
> Doing so is still bitexact.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavformat/mxfenc.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 509cae8442..3bfe2a5c1a 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -762,16 +762,15 @@ static void mxf_write_identification(AVFormatContext *s)
>      AVDictionaryEntry *version_entry = av_dict_get(s->metadata, "product_version", NULL, 0);
>      const char *company = com_entry ? com_entry->value : "FFmpeg";
>      const char *product = product_entry ? product_entry->value : s->oformat != &ff_mxf_opatom_muxer ? "OP1a Muxer" : "OPAtom Muxer";
> -    const char *product_version = version_entry ? version_entry->value : AV_STRINGIFY(LIBAVFORMAT_VERSION);
>      const char *platform = s->flags & AVFMT_FLAG_BITEXACT ? "Lavf" : PLATFROM_IDENT;
> -    const char *version;
> +    const char *version = version_entry ? version_entry->value :
> +                              s->flags & AVFMT_FLAG_BITEXACT ? "0.0.0" :
> +                                  AV_STRINGIFY(LIBAVFORMAT_VERSION);

Looks OK

/Tomas



More information about the ffmpeg-devel mailing list