[FFmpeg-devel] [PATCH 1/3] x86/vf_gblur: fix postscale_slice prologue

[Michael Niedermayer]

On Wed, Feb 17, 2021 at 01:41:04PM -0300, James Almer wrote:
> x86_32 ABI does not pass float arguments directly on xmm regs, and the Win64
> ABI uses only the first four regs for this purpose.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavfilter/vf_gblur.c       |  3 +--
>  libavfilter/x86/vf_gblur.asm | 29 +++++++++++++----------------
>  2 files changed, 14 insertions(+), 18 deletions(-)
> 
> diff --git a/libavfilter/vf_gblur.c b/libavfilter/vf_gblur.c
> index 109a7a95f9..40956e122d 100644
> --- a/libavfilter/vf_gblur.c
> +++ b/libavfilter/vf_gblur.c
> @@ -234,8 +234,7 @@ void ff_gblur_init(GBlurContext *s)
>  {
>      s->horiz_slice = horiz_slice_c;
>      s->postscale_slice = postscale_c;
> -    if (ARCH_X86_64)
> -        ff_gblur_init_x86(s);
> +    ff_gblur_init_x86(s);
>  }

fails on arm

LD	ffmpeg_g
libavfilter/libavfilter.a(vf_gblur.o): In function `ff_gblur_init':
arm/src/libavfilter/vf_gblur.c:237: undefined reference to `ff_gblur_init_x86'
arm/src/libavfilter/vf_gblur.c:237: undefined reference to `ff_gblur_init_x86'
collect2: error: ld returned 1 exit status
Makefile:124: recipe for target 'ffmpeg_g' failed
make: *** [ffmpeg_g] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210217/84da0102/attachment.sig>