[FFmpeg-devel] [PATCH] avformat/protocols: fix discarded-qualifiers compiler warning

Paul B Mahol onemda at gmail.com
Sun Feb 14 19:39:02 EET 2021


On Sun, Feb 14, 2021 at 6:36 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol <onemda at gmail.com
> >:
> >
> > On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
> >
> > > Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi <nuomi2021 at gmail.com
> >:
> > > >
> > > > ---
> > > >  libavformat/protocols.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/libavformat/protocols.c b/libavformat/protocols.c
> > > > index 7df18fbb3b..0b43f66baf 100644
> > > > --- a/libavformat/protocols.c
> > > > +++ b/libavformat/protocols.c
> > > > @@ -111,10 +111,10 @@ const AVClass
> > > *ff_urlcontext_child_class_iterate(void **iter)
> > > >
> > > >  const char *avio_enum_protocols(void **opaque, int output)
> > > >  {
> > > > -    const URLProtocol **p = *opaque;
> > > > +    const URLProtocol *const *p = *opaque;
> > > >
> > > >      p = p ? p + 1 : url_protocols;
> > > > -    *opaque = p;
> > > > +    *opaque = (void*)p;
> > >
> > > I suspect that this is wrong, only avconv's protocols were const.
> > >
> > >
> > That is not valid explanation.
>
> The warning is a regression since a merge commit from Clement (?),
> FFmpeg's protocols are not const iirc.


Look at every protocol definition, they are const.


>
>
Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list