[FFmpeg-devel] [PATCH] avcodec/hevcdec: check that the local context list exists before dereferencing it

Nuo Mi nuomi2021 at gmail.com
Fri Feb 12 06:08:57 EET 2021


On Fri, Feb 12, 2021 at 12:19 AM James Almer <jamrial at gmail.com> wrote:

>
> >>> Signed-off-by: James Almer <jamrial at gmail.com>
> >>> ---
> >>> Maybe ff_frame_thread_free() should not call AVCodec->close() for
> thread
> >> contexts
> >>> where AVCodec->init() failed and FF_CODEC_CAP_INIT_CLEANUP is not set?
> >>>
> >>
> >> Fixing this has been on my to-do list. (The situation is even worse than
> >> you describe it: It is possible that AVCodec->close is called on an
> >> AVCodecContext whose private_data couldn't be allocated.)
> >>
> >
> > So how should proceed? Apply this patch and fix other issues after it?
>
> Applied this patch. The other unchecked allocs are handled in another
> patch, and the ff_frame_thread_init() issues should be fixed by Andreas'
> patch.
>
👍, you are so efficient.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list