[FFmpeg-devel] [PATCH 2/2] lavf/libsrt: deduplicate libsrt_network_wait_fd_timeout

[Marton Balint]

On Mon, 8 Feb 2021, "zhilizhao(赵志立)" wrote:

>
>
>> On Feb 8, 2021, at 2:36 AM, Marton Balint <cus at passwd.hu> wrote:
>> 
>> 
>> 
>> On Mon, 8 Feb 2021, Zhao Zhili wrote:
>> 
>>> ---
>>> libavformat/libsrt.c | 45 +++++++++++++++++---------------------------
>>> 1 file changed, 17 insertions(+), 28 deletions(-)
>> 
>> Hmm, it seems my latest srt patches conflics with this a bit, and you will have to somewhat rebase this, sorry. On the bright side, now only eid is passed to libsrt_network_wait_fd, so maybe you can pass eid instead of fd, especially since it is not always the context->eid that is used for wait.
>
> Thanks for review. Rebase is done:
>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_FF259AEF9F5AAB614E6C70EF2D7A9A684008@qq.com/
>
> libsrt_network_wait_fd_timeout is implemented on top of ff_network_wait_fd_timeout
> to keep minimum code changes. libsrt_network_wait_fd_timeout can be removed if 
> add a NetworkWaitFdCB field to SRTContext but more code need to be changed.
> What do you think?

I think it is fine as is.

Thanks,
Marton