[FFmpeg-devel] [PATCH 1/4] Remove unnecessary mem.h inclusions

Anton Khirnov anton at khirnov.net
Thu Feb 4 12:34:02 EET 2021


Quoting Andreas Rheinhardt (2021-02-04 01:05:05)
> Thanks for the report. I have only checked for whether the relevant
> translation unit uses any of the alloc/free functions (because
> DECLARE_ALIGNED is already provided by mem_internal.h), but I have not
> taken into account stuff that is included by the headers included by
> mem.h. In this case, one needs string.h (which is included in
> libavutil/common.h which in turn is included in avutil.h which is
> included in mem.h). Will look over everything again.
> 
> - Andreas
> 
> PS: It actually seems that the only thing provided by avutil.h that
> mem.h uses is size_t. Do we allow to remove included headers from
> installed headers at major version bumps?

I would say yes, IIRC it has happened before.
Certainly nobody should depend on our headers to provide any random
system headers.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list