[FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Feb 2 11:32:38 EET 2021


Am Di., 2. Feb. 2021 um 04:26 Uhr schrieb Andriy Gelman
<andriy.gelman at gmail.com>:
>
> On Sun, 31. Jan 23:28, Carl Eugen Hoyos wrote:
> > Am So., 31. Jan. 2021 um 20:51 Uhr schrieb Andriy Gelman
> > <andriy.gelman at gmail.com>:
> > >
> > > From: Andriy Gelman <andriy.gelman at gmail.com>
> > >
> > > Xserver defines the endianness of the grabbed images. Use this information
> > > to set the correct pixel format.
> >
> > lgtm if tested.
>
> Thanks, will apply in a few days.
> Do you think I should keep the docker testing instructions in the commit
> message?

If you believe that testing is not trivial (I agree), then this sounds
like a good idea.

> > Could you look at pal8? This used to work fine with x11grab...
>
> Yes sure, will have a look later this week.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list