[FFmpeg-devel] [PATCH v6 3/3] avformat/mxfenc: prefer to use the configured metadta

lance.lmwang at gmail.com lance.lmwang at gmail.com
Mon Feb 1 16:15:24 EET 2021


On Mon, Feb 01, 2021 at 12:05:40PM +0100, Tomas Härdin wrote:
> mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmwang at gmail.com:
> > @@ -724,9 +724,13 @@ static void mxf_write_identification(AVFormatContext *s)
> >  {
> >      MXFContext *mxf = s->priv_data;
> >      AVIOContext *pb = s->pb;
> > -    const char *company = "FFmpeg";
> > -    const char *product = s->oformat != &ff_mxf_opatom_muxer ? "OP1a Muxer" : "OPAtom Muxer";
> > -    const char *version;
> > +    AVDictionaryEntry *com_entry =  av_dict_get(s->metadata, "company_name", NULL, 0);
> > +    AVDictionaryEntry *product_entry =  av_dict_get(s->metadata, "product_name", NULL, 0);
> > +    AVDictionaryEntry *version_entry =  av_dict_get(s->metadata, "product_version", NULL, 0);
> > +    const char *company = com_entry ? com_entry->value : "FFmpeg";
> > +    const char *product = product_entry ? product_entry->value : s->oformat != &ff_mxf_opatom_muxer ? "OP1a Muxer" : "OPAtom Muxer";
> > +    const char *version = NULL;
> 
> Nit: it's not necessary to NULL version

OK, fix it.

> Looks OK
> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang


More information about the ffmpeg-devel mailing list