[FFmpeg-devel] [FFmpeg-cvslog] libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan frame

[Mark Thompson]

On 10/12/2021 16:05, Wenbin Chen wrote:
> ffmpeg | branch: master | Wenbin Chen <wenbin.chen at intel.com> | Tue Dec  7 17:05:50 2021 +0800| [f3c9847c2754b7a43eb721c95e356a53085c2491] | committer: Lynne
> 
> libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan frame
> 
> Vulkan will map nv12 to R8 and GR88, so add this map to vaapi to support
> vulkan frame.
> 
> Signed-off-by: Wenbin Chen <wenbin.chen at intel.com>
> 
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f3c9847c2754b7a43eb721c95e356a53085c2491
> ---
> 
>   libavutil/hwcontext_vaapi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> index 75acc851d6..994b744e4d 100644
> --- a/libavutil/hwcontext_vaapi.c
> +++ b/libavutil/hwcontext_vaapi.c
> @@ -992,6 +992,7 @@ static const struct {
>   } vaapi_drm_format_map[] = {
>   #ifdef DRM_FORMAT_R8
>       DRM_MAP(NV12, 2, DRM_FORMAT_R8,  DRM_FORMAT_RG88),
> +    DRM_MAP(NV12, 2, DRM_FORMAT_R8,  DRM_FORMAT_GR88),
>   #endif
>       DRM_MAP(NV12, 1, DRM_FORMAT_NV12),
>   #if defined(VA_FOURCC_P010) && defined(DRM_FORMAT_R16)

This looks very shady.  Shouldn't one or the other of these be NV21, with the second plane VU rather than UV?

- Mark