[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek <tessarek at evermeet.cx>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hello,
>
> The following 2 commits break the build with a deployment target of 10.9 on
> macOS.
>
> I agree that 10.9 is quite old, but the rest of the code worked perfectly
> fine, so were those 2 commits really necessary?
>
> * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
> vf_yadif_videotoolbox (Aman Karmani)
> * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
> (Aman Karmani)
>
> Can you make that code conditional?
>

To tack on to this, I currently am also experiencing issues with those
commits, but am running on 10.15, however, my issue isn't necessarily that
the code isn't compiling, but rather it seems it's failing to link with

xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air
air-lld: error: library not found for -lmetal_rt_osx_air2.2
metal: error: air-lld command failed with exit code 1 (use -v to see
invocation)
make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1

currently running a fresh clone of FFmpeg and only ran ./configure and then
make. If I run

xcrun metal
-L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin
libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air

then it succeeds, I don't think there's currently a way to export LDFLAGS
to metal as the rule for it is a simple `$(METALCC) $< -o $@`

So I've exported "LIBRARY_PATH" to
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin"
in the profile since I can't easily update that on all of my CI
configurations.