[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

Try with this as well: https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e <https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e>


> On Dec 20, 2021, at 17:49, Helmut K. C. Tessarek <tessarek at evermeet.cx> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Thanks for the rwply.
> 
> On 2021-12-20 18:25, Ridley Combs wrote:
>> Could you try with this patch and let me know if it works for you then? 
>> https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43
> 
> I've applied your patch and get the following now:
> 
> CC	libavfilter/scale_eval.o
> CC	libavfilter/scene_sad.o
> libavfilter/metal/vf_yadif_videotoolbox.metal:47:1: error: constant sampler
> must be declared constexpr
> const sampler s(coord::pixel);
> ^
> constexpr
> libavfilter/metal/vf_yadif_videotoolbox.metal:122:14: error: use of
> undeclared identifier 'max3'
>    T diff = max3(tdiff0, tdiff1, tdiff2);
>             ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:152:9: note: in instantiation
> of function template specialization 'temporal_predictor<float>' requested here
>        temporal_predictor(A.x, B.x, C.x, D.x, E.x, F.x,
>        ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:125:18: error: use of
> undeclared identifier 'max3'
>        T maxi = max3(p2 - p3, p2 - p1, min(p0 - p1, p4 - p3));
>                 ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:126:18: error: use of
> undeclared identifier 'min3'
>        T mini = min3(p2 - p3, p2 - p1, max(p0 - p1, p4 - p3));
>                 ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:217:12: error: no matching
> function for call to 'temporal_predictor'
>    return temporal_predictor(A, B, C, D, E, F, G, H, I, J, K, L,
>           ^~~~~~~~~~~~~~~~~~
> libavfilter/metal/vf_yadif_videotoolbox.metal:233:16: note: in instantiation
> of function template specialization 'yadif_compute_temporal<float>'
> requested here
>        return yadif_compute_temporal(cur, prev, cur, next, next,
> spatial_pred, params.skip_spatial_check, pos);
>               ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:265:23: note: in instantiation
> of function template specialization 'yadif<float>' requested here
>        pred = float2(yadif<float>(dst, prev, cur, next, params, pos));
>                      ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:108:3: note: candidate
> template ignored: substitution failure [with T = float]
> T temporal_predictor(T A, T B, T C, T D, T E, T F,
>  ^
> 5 errors generated.
> make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
> make: *** Waiting for unfinished jobs....
> libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
> not found (return type defaults to 'id') [-Wobjc-method-access]
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                    ^~~~~~~~~~~~~~
> libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
> 'MTLGPUFamilyCommon3'
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                                   ^
> 1 warning and 1 error generated.
> make: *** [libavfilter/metal/utils.o] Error 1
> Error compiling ffmpeg...
> 
>> If you can test actual deployment on a 10.9 or 10.10 system that'd be
>> great.
> 
> Unfortunately I don't have a 10.9 or 10.10 system. I compile on macOS 1.14
> with export MACOSX_DEPLOYMENT_TARGET=10.9
> 
> Cheers,
>  K. C.
> 
> - -- 
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
> 
> /*
>   Thou shalt not follow the NULL pointer for chaos and madness
>   await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
> 
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBFpsACgkQvgmFNJ1E
> 3QDapA//WmxnoAqIGCqliaSIUpRkL/KxhSpj9ULJzL1h9yw6Ls0DIYT39Pa66hTk
> IABKgLiTNxe1hNTC9kbXf6HdNqJw7KGGUlCGu777RHhh7wySq355g7b89f1wrSJa
> 1RwCkb9EoyC/DzeSnayDk6oOO7duJxCibkdTXEsYW9VgA9QGSriTHIRSG666UgXO
> NC6EyjiOfGqlVkTr9Ott+r2t30H/0faihttbIhLwV6y/Dd/vx4mdG4y61B0PXLX1
> rAQwDP9GYkAa302XLeLSTTJ/IHzsV7xD1eE+I3QcB63gbzKlujfbSBiOf9Czv6Vs
> M1xoRbcqYkTi7zK45t7w+FuAMn/her/P5cCjmXbEQIHBZEfX3r2MKtkdIAhHsUPl
> vDvR7Zmi90gRorQnyQ1fy/LaIcZt6E6CFPKQrIVkBsOnIuXvnrx4fxsvo4rYO32p
> goyhtmBMyg9zIZy4eSUn/3M5NKMifgSQrYdUIIKrJZr4ENesKTGB/EZXS30v5VF4
> 7GrObWDT1oR+VoUiMSYrGPSBlF8R/NHJGU/BL7iVFtF7CfFRnHmfgzyII8RlS6G+
> V5stD8eKNr/8fzI3sjQfiROEMtLFKJz4Zkf6qmBT7zeDizNJp/xaGc2egsC7LMzX
> or7vCtN6YKPXhQimhsrxDvIXLdvt2ZsCwcbNpq5ZzEMi8mDgwCs=
> =DJOy
> -----END PGP SIGNATURE-----