[FFmpeg-devel] [PATCH v13 1/2] avformat/imf: Demuxer

[Pierre-Anthony Lemieux]

On Mon, Dec 20, 2021 at 11:19 AM Lynne <dev at lynne.ee> wrote:
>
> 20 Dec 2021, 19:57 by pal at sandflow.com:
>
> > From: Pierre-Anthony Lemieux <pal at palemieux.com>
> >
> > Signed-off-by: Pierre-Anthony Lemieux <pal at palemieux.com>
> > ---
> >
> > Notes:
> >  The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be
> >  contained in multiple deliveries, each defined by an ASSETMAP file:
> >
> >  ffmpeg -assetmaps <path of ASSETMAP1>,<path of ASSETMAP>,... -i <path of CPL>
> >
> >  If -assetmaps is not specified, FFMPEG looks for a file called ASSETMAP.xml in the same directory as the CPL.
> >
> >  EXAMPLE:
> >  ffmpeg -i http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml out.mp4
> >
> >  The Interoperable Master Format (IMF) is a file-based media format for the
> >  delivery and storage of professional audio-visual masters.
> >  An IMF Composition consists of an XML playlist (the Composition Playlist)
> >  and a collection of MXF files (the Track Files). The Composition Playlist (CPL)
> >  assembles the Track Files onto a timeline, which consists of multiple tracks.
> >  The location of the Track Files referenced by the Composition Playlist is stored
> >  in one or more XML documents called Asset Maps. More details at https://www.imfug.com/explainer.
> >  The IMF standard was first introduced in 2013 and is managed by the SMPTE.
> >
> >  CHANGE NOTES:
> >
> >  - added libavformat/tests/imf to FATE
> >
> >  MAINTAINERS              |   1 +
> >  configure                |   3 +-
> >  doc/demuxers.texi        |   6 +
> >  libavformat/Makefile     |   1 +
> >  libavformat/allformats.c |   1 +
> >  libavformat/imf.h        | 207 +++++++++
> >  libavformat/imf_cpl.c    | 800 +++++++++++++++++++++++++++++++++++
> >  libavformat/imfdec.c     | 891 +++++++++++++++++++++++++++++++++++++++
> >  8 files changed, 1909 insertions(+), 1 deletion(-)
> >  create mode 100644 libavformat/imf.h
> >  create mode 100644 libavformat/imf_cpl.c
> >  create mode 100644 libavformat/imfdec.c
> >
>
> You've once again gone back and completely ignored all coding style
> issues I pointed out.

This was definitely not the intent, and I do not believe that *ignored
all coding style* is accurate. For example, most of the suggestions
you made at [1] on December 5 have been integrated, including: using
ff_<name> for internal functions, using FF<name> for structs, reducing
line length, etc.

It might be that some of the changes you suggested conflicted with
changes that others suggested.

Regarding the use of libuuid, I believe this should be done after the
patch is merged since it affects other parts of the system and libuuid
cannot be used as-is. I am happy to volunteer to lead such an effort,
as suggested before.

[1] http://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/288853.html

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".