[FFmpeg-devel] [PATCH] avfilter: add yadif implementation using Metal.framework

Aman Karmani ffmpeg at tmm1.net
Tue Dec 14 04:38:00 EET 2021


On Mon, Dec 13, 2021 at 6:21 PM Lynne <dev at lynne.ee> wrote:

> 14 Dec 2021, 02:47 by ffmpeg at tmm1.net:
>
> > From: Aman Karmani <aman at tmm1.net>
> >
> > deinterlaces CVPixelBuffers, i.e. AV_PIX_FMT_VIDEOTOOLBOX frames
> >
> > for example, an interlaced mpeg2 file can be decoded by avcodec,
> > uploaded into a CVPixelBuffer, deinterlaced by metal, and then
> > encoded to h264 by VideoToolbox as follows:
> >
> >  ffmpeg \
> >  -init_hw_device videotoolbox \
> >  -i interlaced.ts \
> >  -vf hwupload,deinterlace_metal=mode=send_field:deint=interlaced \
> >  -c:v h264_videotoolbox \
> >  -b:v 2000k \
> >  -c:a copy \
> >  -y progressive.ts
> >
> > (note that uploading AVFrame into CVPixelBuffer via hwupload
> >  requires 504c60660d3194758823ddd45ceddb86e35d806f)
> >
> > Signed-off-by: Aman Karmani <aman at tmm1.net>
> >
>
> Should be called yadif_videotoolbox, not yadif_metal. Hardware filters
> are named after the hardware context that they take, not what they
> use as an API.
>

Thanks. I can rename to deinterlace_videotoolbox, which would mirror things
like deinterlace_qsv

I would prefer not to call it yadif_videotoolbox, because I think
additional algorithms would be more easily implemented in the same filter
vs copy/pasting the entire harness.

Aman


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>


More information about the ffmpeg-devel mailing list