[FFmpeg-devel] [PATCH v2] avfilter/dnn: fix incompatible integer to pointer conversion warning

[lance.lmwang at gmail.com]

On Sat, Dec 11, 2021 at 03:06:42AM +0000, Guo, Yejun wrote:
> 
> 
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of lance.lmwang at gmail.com
> Sent: 2021年12月9日 22:37
> To: ffmpeg-devel at ffmpeg.org
> Cc: Limin Wang <lance.lmwang at gmail.com>
> Subject: [FFmpeg-devel] [PATCH v2] avfilter/dnn: fix incompatible integer to pointer conversion warning
> 
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> ---
>  libavfilter/dnn/dnn_backend_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/dnn/dnn_backend_common.c b/libavfilter/dnn/dnn_backend_common.c
> index 6a9c4cc..dd7bdf4 100644
> --- a/libavfilter/dnn/dnn_backend_common.c
> +++ b/libavfilter/dnn/dnn_backend_common.c
> @@ -83,10 +83,10 @@ static void *async_thread_routine(void *args)
>      void *request = async_module->args;
>  
>      if (async_module->start_inference(request) != DNN_SUCCESS) {
> -        return DNN_ASYNC_FAIL;
> +        return (void*)DNN_ASYNC_FAIL;
> 
> there is already (void*) in DNN_ASYNC_FAIL

Sorry, it's my mistake. please ignore the patch.
Can we check the thread_join status with void* and void* error code? 
if (status == DNN_ASYNC_FAIL) {

For the compiler doesnt know what type of address the pointer is pointing at,
it doesnt know how many bytes to read from the pointer address and compare. 

> 
>      }
>      async_module->callback(request);
> -    return DNN_ASYNC_SUCCESS;
> +    return (void*)DNN_ASYNC_SUCCESS;
>  }
>  
>  DNNReturnType ff_dnn_async_module_cleanup(DNNAsyncExecModule *async_module)
> --
> 1.8.3.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang