[FFmpeg-devel] [PATCH] fate: add audio tests for Silicon Graphics Movie format

[Andreas Rheinhardt]

Anton Khirnov:
> Quoting Peter Ross (2021-12-06 08:48:08)
>> Signed-off-by: Peter Ross <pross at xvid.org>
>> ---
>>
>> Miminimal test vectors attached.
>> Can somebody help upload them to $SAMPLES/mv folder on rsync server?
>>
>>  tests/fate/audio.mak          | 12 ++++++++++++
>>  tests/ref/fate/mv-mono16bit   |  8 ++++++++
>>  tests/ref/fate/mv-mono8bit    |  8 ++++++++
>>  tests/ref/fate/mv-stereo16bit |  8 ++++++++
>>  tests/ref/fate/mv-stereo8bit  |  8 ++++++++
>>  5 files changed, 44 insertions(+)
>>  create mode 100644 tests/ref/fate/mv-mono16bit
>>  create mode 100644 tests/ref/fate/mv-mono8bit
>>  create mode 100644 tests/ref/fate/mv-stereo16bit
>>  create mode 100644 tests/ref/fate/mv-stereo8bit
>>
>> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
>> index fd9905ca0a..ed7ad9c220 100644
>> --- a/tests/fate/audio.mak
>> +++ b/tests/fate/audio.mak
>> @@ -38,6 +38,18 @@ fate-imc: CMD = pcm -i $(TARGET_SAMPLES)/imc/imc.avi
>>  fate-imc: CMP = oneoff
>>  fate-imc: REF = $(SAMPLES)/imc/imc-201706.pcm
>>  
>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, MV, PCM_S8) += fate-mv-mono8bit
>> +fate-mv-mono8bit: CMD = framecrc -i $(TARGET_SAMPLES)/mv/mono8bit-minimal.movie -vn -af aresample
>> +
>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, MV, PCM_S16BE) += fate-mv-mono16bit
>> +fate-mv-mono16bit: CMD = framecrc -i $(TARGET_SAMPLES)/mv/mono16bit-minimal.movie -vn -af aresample
>> +
>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, MV, PCM_S8) += fate-mv-stereo8bit
>> +fate-mv-stereo8bit: CMD = framecrc -i $(TARGET_SAMPLES)/mv/stereo8bit-minimal.movie -vn -af aresample
>> +
>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, MV, PCM_S16BE) += fate-mv-stereo16bit
>> +fate-mv-stereo16bit: CMD = framecrc -i $(TARGET_SAMPLES)/mv/stereo16bit-minimal.movie -vn -af aresample
> 
> Why -af aresample? Is that even bitexact?
> 

A conversion of non-float formats is bitexact (if it isn't, it should be
treated as a bug). The pcm_s16be decoder outputs the same sample format
as the pcm_s16le encoder accepts, so aresample should be unnecessary in
these cases, but not for the pcm_s8 case. Of course, one could also just
copy the audio instead of decoding. This would also have the advantage
that the actual requirements of this test better match the stated
requirements: These tests currently all need the aresample filter, but
DEMDEC does not check for this. As a result, these tests will fail e.g.
with --disable-swscale.

- Andreas