[FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame for subtitle handling

Hendrik Leppkes h.leppkes at gmail.com
Mon Dec 6 01:37:21 EET 2021


On Mon, Dec 6, 2021 at 12:23 AM Soft Works <softworkz at hotmail.com> wrote:
>
> It can only work like that.
>

You literally designed subtitle filtering. You defined how it works.
All your explanations come down to some fancy form of "because I made
it required".

All I'm hearing is that some internal mechanisms in avfilter need it.
Why is it a public field in one of the most key structures in our
entire codebase? You understand this concern, right? Any public field
should first (and only) answer the question, what information does
this convey to the user? Does the user need this information? I'm not
seeing any of that in your explanations. All I'm seeing is internal
avfilter workings - cemented in public API.

You are not integrating into an existing infrastructure, you are
literally trying to add the whole thing, so you can change it to not
need this redundant field.

- Hendrik


More information about the ffmpeg-devel mailing list