[FFmpeg-devel] [PATCH v3 1/2] avformat/rtsp: load the sdp file with avio_read_to_bprint()

[lance.lmwang at gmail.com]

On Fri, Dec 03, 2021 at 02:50:14PM +0100, Michael Niedermayer wrote:
> On Fri, Dec 03, 2021 at 09:14:12PM +0800, lance.lmwang at gmail.com wrote:
> > On Thu, Dec 02, 2021 at 11:52:23PM +0100, Michael Niedermayer wrote:
> > > On Thu, Dec 02, 2021 at 06:37:38PM +0800, lance.lmwang at gmail.com wrote:
> > > > From: Limin Wang <lance.lmwang at gmail.com>
> > > > 
> > > > this allows getting rid of the hardcoded max size of SDP.
> > > > 
> > > > Reviewed-by: Martin Storsjö <martin at martin.st>
> > > > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > > > ---
> > > >  libavformat/rtsp.c | 25 +++++++++----------------
> > > >  1 file changed, 9 insertions(+), 16 deletions(-)
> > > 
> > > This seems to break things
> > > 
> > > cvlc --play-and-exit ~/videos/stream2962.ts --sout="#rtp{dst=127.0.0.1,port=4414,sdp=rtsp://127.0.0.1:9180/test.sdp, mux=ts}" >  /tmp/log.1 2> /tmp/log.2 & ./ffmpeg -i rtp://127.0.0.1:4414 -t 1 -bitexact -y out2962.avi
> > > 
> > > before this patch
> > > frame=   14 fps=0.0 q=2.0 Lsize=      38kB time=00:00:01.00 bitrate= 309.2kbits/s speed= 117x    
> > > video:32kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 19.610027%
> > > 
> > > after:
> > > rtp://127.0.0.1:4414: Invalid argument
> > 
> > Michael, I have submit one more fix for the break. After apply below patch(patch#1), it'll working without error. Please 
> > check whether it fixed your issue. 
> > 
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/1638507433-5005-1-git-send-email-lance.lmwang@gmail.com/
> 
> confirmed the failure is fixed

Thanks for the confirmed, then I'll applied the patch first before the two patch applied.

> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The worst form of inequality is to try to make unequal things equal.
> -- Aristotle



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


-- 
Thanks,
Limin Wang