[FFmpeg-devel] [PATCH] hwcontext_vulkan: make 2 public functions always available

Michael Niedermayer michael at niedermayer.cc
Fri Dec 3 11:51:44 EET 2021


On Thu, Dec 02, 2021 at 07:01:08PM +0100, Lynne wrote:
> The issue is that if ffmpeg is compiled without Vulkan, and an API 
> user includes and uses the functions exposed in hwcontext_vulkan.h,
> then a linking error will happen, as the hwcontext_vulkan.c file has
> not been compiled.
> 
> Move the functions to another file, and make it always compiled. The
> functions do not use any Vulkan functions.
> 
> Patch attached.

>  Makefile                  |    1 
>  hwcontext_vulkan.c        |   86 -------------------------------------
>  hwcontext_vulkan_common.c |  105 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 106 insertions(+), 86 deletions(-)
> 8ad8f8dbe2c3e9695073e7a05f406865ae04d0f9  0001-hwcontext_vulkan-make-2-public-functions-always-avai.patch
> From ccd4aed173ea3e668ccf767d3a1ef6bef155ea48 Mon Sep 17 00:00:00 2001
> From: Lynne <dev at lynne.ee>
> Date: Thu, 2 Dec 2021 18:55:39 +0100
> Subject: [PATCH] hwcontext_vulkan: make 2 public functions always available

This breaks build on mingw64

In file included from src/libavutil/hwcontext_vulkan_common.c:19:0:
src/libavutil/hwcontext_vulkan.h:25:10: fatal error: vulkan/vulkan.h: No such file or directory
 #include <vulkan/vulkan.h>

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211203/1f21c3ea/attachment.sig>


More information about the ffmpeg-devel mailing list