[FFmpeg-devel] [PATCH 1/2] avdevice/lavfi: Properly free an AVDictionary

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Dec 2 18:15:47 EET 2021


It is not documented that freeing the last (and only) entry of
an AVDictionary frees the dictionary.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavdevice/lavfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
index 826dafbd00..d9083ad984 100644
--- a/libavdevice/lavfi.c
+++ b/libavdevice/lavfi.c
@@ -150,7 +150,7 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
         if (avctx->protocol_whitelist && (ret = av_dict_set(&options, "protocol_whitelist", avctx->protocol_whitelist, 0)) < 0)
             goto end;
         ret = avio_open2(&avio, lavfi->graph_filename, AVIO_FLAG_READ, &avctx->interrupt_callback, &options);
-        av_dict_set(&options, "protocol_whitelist", NULL, 0);
+        av_dict_free(&options);
         if (ret < 0)
             goto end;
         av_bprint_init(&graph_file_pb, 0, AV_BPRINT_SIZE_UNLIMITED);
-- 
2.32.0



More information about the ffmpeg-devel mailing list