[FFmpeg-devel] [PATCH] avcodec/videotoolbox: fix use of unknown builtin '__builtin_available'

[Hendrik Leppkes]

On Thu, Dec 2, 2021 at 2:20 PM <lance.lmwang at gmail.com> wrote:
>
> From: Limin Wang <lance.lmwang at gmail.com>
>
> Old system is:
> OSX version: 10.11.6
> Apple LLVM version 8.0.0 (clang-800.0.42.1)
> Target: x86_64-apple-darwin15.6.0
>
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavcodec/videotoolbox.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index 284da97..195706c 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -895,7 +895,7 @@ static int videotoolbox_start(AVCodecContext *avctx)
>          break;
>      }
>
> -#if defined(MAC_OS_X_VERSION_10_9) && !TARGET_OS_IPHONE && (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_9)
> +#if defined(MAC_OS_X_VERSION_10_9) && !TARGET_OS_IPHONE && (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_9) && AV_HAS_BUILTIN(__builtin_available)
>      if (avctx->codec_id == AV_CODEC_ID_PRORES) {
>          if (__builtin_available(macOS 10.9, *)) {
>              VTRegisterProfessionalVideoWorkflowVideoDecoders();
> @@ -903,7 +903,7 @@ static int videotoolbox_start(AVCodecContext *avctx)
>      }
>  #endif
>
> -#if defined(MAC_OS_VERSION_11_0) && !TARGET_OS_IPHONE && (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_VERSION_11_0)
> +#if __clang_major__ >= 9 && defined(MAC_OS_VERSION_11_0) && !TARGET_OS_IPHONE && (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_VERSION_11_0) && AV_HAS_BUILTIN(__builtin_available)
>      if (__builtin_available(macOS 11.0, *)) {
>          VTRegisterSupplementalVideoDecoderIfAvailable(videotoolbox->cm_codec_type);
>      }

Any reason these checks are different, one with a clang version check,
one without?

- Hendrik