[FFmpeg-devel] [PATCH 2/6] lavf/concat: add file_packet_meta directive

[Nicolas George]

Andreas Rheinhardt (12021-08-31):
> You seem to misunderstand the semantics of the AV_DICT_DONT_STRDUP_*
> flags: av_dict_set() takes complete ownership of the strings, even on
> errors. So in case of errors the above code would lead to a double-free.
> Patches #1 and #4 of this set are also affected by this.

Thanks, I made the same mistake last time. It is counter-intuitive:
realloc() does not free its argument if it fails, for example. Anyway,
fixed by moving the =NULL earlier.

Stand by for a new version with more features.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210831/d3c1f719/attachment.sig>