[FFmpeg-devel] [PATCH v2 0/8] A New Take on the Immortal Sub2Video Code

Nicolas George george at nsup.org
Mon Aug 30 11:24:01 EEST 2021


Soft Works (12021-08-30):
> v2 Update:
> 
> - Implemented Andreas' suggestions
> - overlay_subs filter:
>   - removed duplicated code
>   - implemented direct (no pre-conversion) blending of graphical
>     subtitle rects
>   - Supported input formats:
>     - all packed RGB formats (with and without alpha)
> 	- yuv420p, yuv422p, yuv444p
> 
> 
> This patchset is about introducing filtering support for subtitles.

Rejected.

As I have explained to you, no subtitle support can be accepted until
the negotiation process has been refactored to make adding a third media
type less of a nightmare.

From your questions and remarks in other discussions, it seems obvious
to me that you are missing something central about the format
negotiation. That makes discussion with you at cross-purpose, a waste of
your efforts and ours both, and that makes your patches unacceptable.

So, if you really want to contribute, I strongly suggest you stop
insisting on what you already wrote, and take the time to read the code
in depth to understand how it works and how it needs to be made better.
Then you can prove to yourself your understanding by submitting FATE
tests for the parts that are not yet covered, as I suggested recently.

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210830/865a2c31/attachment.sig>


More information about the ffmpeg-devel mailing list