[FFmpeg-devel] [PATCH] avcodec/truemotion1: Cleanup prediction code in truemotion1_decode_16bit and truemotion1_decode_24bit

Soft Works softworkz at hotmail.com
Thu Aug 26 10:34:55 EEST 2021



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Moritz Barsnick
> Sent: Thursday, 26 August 2021 09:25
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/truemotion1: Cleanup
> prediction code in truemotion1_decode_16bit and
> truemotion1_decode_24bit
> 
 
> As much as you praise the "graphical stuff" over the mailing list
> approach: Was your graphical editor not capable of showing you these
> issues? Hint: Review your commit (git diff before commit, git show
> afterwards) before submitting it. (And whether "graphical stuff" is
> greater or not, you would still have to correct errors by creating a
> modified commit. And with github pull requests, you'd need to re-
> branch
> or to force-push. Not much ease in the process there.)

Force-pushing to the PR branch is nicely easing the process IMO.

softworkz


More information about the ffmpeg-devel mailing list